Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): install resource requirements flag #2207

Merged
merged 5 commits into from
Apr 13, 2021

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Apr 13, 2021

Adding a flag to allow setting operator Pod resources as specified in https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/

With this PR we can install the operator (both regular and OLM) specifing resources such as memory and CPU, ie:

kamel install --operator-resources limits.memory=256Mi --operator-resources limits.cpu=500m

Release Note

feat(cmd): install operator resource requirements option

@squakez
Copy link
Contributor Author

squakez commented Apr 13, 2021

cc @astefanutti you may have a look at this as it is similar to other installation requirements we introduced lately, thanks!

@squakez squakez force-pushed the feat/resources_requirements branch from 0803762 to 6d96b7c Compare April 13, 2021 07:31
Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! May I suggest to rename the --resources-requirements option to --operator-resources, so that it's explicit it concerns the operator, as the install command manages other resources, like the CRDs.

@astefanutti astefanutti merged commit 39a4501 into apache:master Apr 13, 2021
@astefanutti
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants