Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): Default to routine build strategy for local IntegrationPlatform #2240

Merged
merged 1 commit into from
Apr 28, 2021
Merged

fix(build): Default to routine build strategy for local IntegrationPlatform #2240

merged 1 commit into from
Apr 28, 2021

Conversation

astefanutti
Copy link
Member

Release Note

fix(build): Default to routine build strategy for local IntegrationPlatform

christophd
christophd approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@orpiske
Copy link
Contributor

orpiske commented Apr 28, 2021

I was a having a similar problem with K3s. I tried this patch and it solved the problem!

nicolaferraro
nicolaferraro approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just using the best supported strategy seems right. Can you backport it also to the 1.4.x branch?

@astefanutti
Copy link
Member Author

Yeah, just using the best supported strategy seems right. Can you backport it also to the 1.4.x branch?

Sure, I was waiting for your validation before. Better having four-eyes review on that :)

@astefanutti astefanutti merged commit 649271c into apache:main Apr 28, 2021
@astefanutti astefanutti deleted the pr-238 branch April 28, 2021 13:22
@nicolaferraro nicolaferraro mentioned this pull request Jul 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophd christophd christophd approved these changes

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@astefanutti @orpiske @christophd @nicolaferraro @oscerd