Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: generated API #2274

Merged
merged 2 commits into from
May 10, 2021
Merged

Doc: generated API #2274

merged 2 commits into from
May 10, 2021

Conversation

squakez
Copy link
Contributor

@squakez squakez commented May 7, 2021

With this PR we introduce a new script which is in charge to generate an html single page with the definition of the API. We use the project https://github.com/ahmetb/gen-crd-api-reference-docs by temporary downloading the binary needed to run the generation.

I've changed the generate-doc procedure to include the execution of this script that will update the API definition file as expected by the documentation

We include that file in a document that will be exposed in the documentation.

Close #1137

Release Note

Doc: generated API

Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot, looking forward to see how it looks!

script/gen_crd/gen_crd_api.sh Show resolved Hide resolved
@squakez
Copy link
Contributor Author

squakez commented May 7, 2021

Woot, looking forward to see how it looks!

We'll have to be more disciplined and comment properly throughout the code. We have many bold spots... in any case it's a good start I guess :)

@astefanutti
Copy link
Member

astefanutti commented May 7, 2021

We'll have to be more disciplined and comment properly throughout the code. We have many bold spots... in any case it's a good start I guess :)

Right. This what makes me excited about finally having the documentation generated out of the CRDs. It help raising awareness that the CRDs are APIs, that deserve proper documentation!

@astefanutti
Copy link
Member

@zregvart just a heads-up in case you want to chime in?

@zregvart
Copy link
Member

A good followup would be to convert the templates to asciidoc instead of using HTML here, not sure if/how it'll render on the website.

@squakez
Copy link
Contributor Author

squakez commented May 10, 2021

A good followup would be to convert the templates to asciidoc instead of using HTML here, not sure if/how it'll render on the website.

Yeah, right now it's just a quick way to start it. I'd include follow up issues in order to go ahead and refine iteratively once we merge this.

@astefanutti astefanutti merged commit 6947a97 into apache:main May 10, 2021
@zregvart
Copy link
Member

There are a few broken links, list can be seen in this website build.

@nicolaferraro nicolaferraro mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate CRD documentation for website
3 participants