Normalize the Spectrum log messages

[orpiske]

Fixes GH issue #2276

Release Note

Normalize Spectrum build messages

[orpiske]

This is how they look like

[astefanutti]

In order to prevent regression from unstructured log statements sneaking in, it would be useful to add an e2e test, that unmarshalls the operator logs.

An option could be added to:

camel-k/e2e/support/test_support.go

Line 289 in 0d172b6

if err != nil {

in order to error the test in that case.

[orpiske]

In order to prevent regression from unstructured log statements sneaking in, it would be useful to add an e2e test, that unmarshalls the operator logs.

An option could be added to:

camel-k/e2e/support/test_support.go

Line 289 in 0d172b6

if err != nil {

in order to error the test in that case.

Thanks. That's a good idea. I'll implement that.

[orpiske]

I am working on the test case for this. It took me a while to get Kind running locally.

[orpiske]

@astefanutti I think we'll have to leave the integration test for a separate PR. We have other log messages that are non-structured. They are not printed by our code directly, instead they are printed by dependencies (i.e.: leader election from k8s is one of the offending code). So we'll have to review those before introducing a test for this.

If you are OK with that, my suggestion is to go as it is and I'll open another issue for myself related to the remaining non-structured bits ... and that one will contain a test for the structured logging.

wdyt?

[astefanutti]

@orpiske thanks a lot for the update!

Indeed, structured logging is still in alpha in Kubernetes 1.19:
https://kubernetes.io/blog/2020/09/04/kubernetes-1-19-introducing-structured-logs/. It's also not really clear how to activate structured logging in client-go (which hosts the leader election code that controller-runtime calls), maybe klog.SetLogger() can be used?

I agree with your suggestion to merge this, and create a follow up issue. In addition to fixing the Spectrum case, this PR has also helped identifying the remaining bits 👍🏼.

[orpiske]

@orpiske thanks a lot for the update!

Indeed, structured logging is still in alpha in Kubernetes 1.19:
https://kubernetes.io/blog/2020/09/04/kubernetes-1-19-introducing-structured-logs/. It's also not really clear how to activate structured logging in client-go (which hosts the leader election code that controller-runtime calls), maybe klog.SetLogger() can be used?

I agree with your suggestion to merge this, and create a follow up issue. In addition to fixing the Spectrum case, this PR has also helped identifying the remaining bits 👍🏼.

Thanks! I opened #2286 and I will explore that one next.