feat(cmd): build-property flag #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The operator panicked because some equality on slices. * Checking if the kit has no traits which was always having the comparison succesful
* Included a build-time-properties in Builder trait to provide the Build task the ability to add build time properties. * Introduced a new flag which will allow the user to introduce build time properties. It will convert into build-time-properties, as expected by the Builder trait.
squakez
commented
May 18, 2021
nicolaferraro
approved these changes
May 25, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we are introducing a new parameter,
--build-property, whose goal is to let the user specify any configuration needed at build time. For example:Will provide the
quarkus.application.nameto the properties expected by the build tasks, setting, in this case, the name of the application as expected bycamel-quarkus.Ref #2003
Release Note