Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/run): property configuration refactoring #2329

Merged
merged 11 commits into from
May 27, 2021

Conversation

squakez
Copy link
Contributor

@squakez squakez commented May 26, 2021

With this PR we finalize the refactoring of build and runtime configuration properties as described in #2003 :

  • build-property file support (ie kamel run --build-property file:conf.properties ...)
  • new property file format as build-property (ie kamel run --property file:conf.properties ...)
  • deprecation of --property-file in favor of --property file:conf.properties
  • modeline support for --property and --build-property flag
  • E2E test for all the supported properties file flags
  • Full set of examples for all properties flags (also with modeline enabled)

The original issue was mentioning the creation of a --config-property flag. However, I think it's better to keep the usage of --property which is already widely used and quite meaningful among developers.

Release Note

feat(cmd/run): property configuration refactoring

Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@nicolaferraro nicolaferraro merged commit e622575 into apache:main May 27, 2021
@nicolaferraro nicolaferraro mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants