Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trait: add builder trait #233

Merged
merged 4 commits into from
Nov 22, 2018
Merged

trait: add builder trait #233

merged 4 commits into from
Nov 22, 2018

Conversation

lburgazzoli
Copy link
Contributor

No description provided.

@lburgazzoli lburgazzoli changed the title trait: add builder trait -o trait: add builder trait Nov 20, 2018
nicolaferraro
nicolaferraro approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring!

pkg/trait/trait.go Outdated Show resolved Hide resolved
@nicolaferraro nicolaferraro merged commit c104443 into apache:master Nov 22, 2018
@lburgazzoli lburgazzoli deleted the builder-trait branch November 22, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lburgazzoli @nicolaferraro @oscerd