feat(cmd/run): --config option flag #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introducing --config [configmap|secret|file]:name * Deprecate --configmap and --secret Ref apache#2003
The old config flag is clashing with the new one that we want to introduce for run subcommand. It makes sense to rename it as --kube-config as it makes reference to kube configuration file. Ref apache#2003
nicolaferraro
approved these changes
May 27, 2021
|
@nicolaferraro, I've added d4077a4 to this PR in order to check if a |
nicolaferraro
requested changes
Jun 1, 2021
Introduced a new list of flags that accept multiple values. If they are passed a file: syntax, the value will be expanded with the relative file location
|
@nicolaferraro, I've added 5765133 which should fix the concerns related to the modeline. Indeed, that problem was wider as it was affecting the rest of flags that were using |
nicolaferraro
approved these changes
Jun 3, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we are:
--config [configmap|secret|file]:namerun option flag--configmapand--secretrun option flag--configglobal flag with--kube-config--configThe goal is to provide a unique
configflag to manage all different kind of configuration as explained in #2003. This flag eventually differs fromresourceas it is meant to only provide configuration files that will be evaluated by theIntegrationruntime.Release Note