Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting deadline seconds #2342

Merged
merged 4 commits into from
Jun 4, 2021
Merged

Starting deadline seconds #2342

merged 4 commits into from
Jun 4, 2021

Conversation

zach-robinson
Copy link
Contributor

@zach-robinson zach-robinson commented May 28, 2021 •
edited
Loading

Adds the starting-deadline-seconds property to the cron trait.

resolves #2330

Release Note

NONE

astefanutti
astefanutti approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please run make generate-doc to update the trait documentation. Thanks!

@zach-robinson
Copy link
Contributor Author

@astefanutti Done: 56e2096

@astefanutti
Copy link
Member

@zach-robinson thanks. Could you please remove the docs/modules/ROOT/pages/apis/crds-html.adoc file from the changes? It's not related to this PR. Thanks.

@zach-robinson
Copy link
Contributor Author

@astefanutti Done.

@astefanutti
Copy link
Member

@zach-robinson thanks, I've started CI and we'll merge it once it has completed.

@astefanutti astefanutti merged commit 403509d into apache:main Jun 4, 2021
@astefanutti
Copy link
Member

Thanks.

@nicolaferraro nicolaferraro mentioned this pull request Jul 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Property in cron trait to set startingDeadlineSeconds
3 participants
@zach-robinson @astefanutti @oscerd