Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for spring boot #239

Merged
merged 3 commits into from
Nov 26, 2018
Merged

support for spring boot #239

merged 3 commits into from
Nov 26, 2018

Conversation

lburgazzoli
Copy link
Contributor

No description provided.

Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and open points...

runtime/spring-boot/pom.xml Outdated Show resolved Hide resolved
runtime/spring-boot/pom.xml Outdated Show resolved Hide resolved
}

@Bean
public RouteBuilder routes(ConfigurableApplicationContext applicationContext) throws Exception {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already seen this code somewhere else...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where ?

pkg/builder/builder_steps.go Show resolved Hide resolved
pkg/builder/builder_types.go Outdated Show resolved Hide resolved
@lburgazzoli
Copy link
Contributor Author

@nicolaferraro I should have fixed almost all your questions/concerns. I still need to investigate the incremental deployment that appears not to work very well here.

@lburgazzoli lburgazzoli changed the title initial support for spring boot support for spring boot Nov 24, 2018
@lburgazzoli
Copy link
Contributor Author

best image issue fixed

Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Very good!

@nicolaferraro
Copy link
Member

Can you resolve the conflicts before merging?

@lburgazzoli
Copy link
Contributor Author

@nicolaferraro done

@nicolaferraro nicolaferraro merged commit 03bcfd8 into apache:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants