initial code for integration context #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lburgazzoli
force-pushed
the
integration-context
branch
from
3ca3900
to
39c5668
Compare
oscerd
approved these changes
Sep 11, 2018
lburgazzoli
force-pushed
the
integration-context
branch
2 times, most recently
from
c3f3f54
to
7fe398f
Compare
nicolaferraro
requested changes
Sep 11, 2018
Gopkg.lock
Outdated
| @@ -2,230 +2,179 @@ | |||
|
|
|||
|
|
|||
| [[projects]] | |||
| digest = "1:5c3894b2aa4d6bead0ceeea6831b305d62879c871780e7b76296ded1b004bc57" | |||
There was a problem hiding this comment.
Can you move to "dep 0.5.0"?
pkg/apis/camel/v1alpha1/types.go
Outdated
| @@ -36,6 +36,7 @@ type Integration struct { | |||
| metav1.ObjectMeta `json:"metadata"` | |||
| Spec IntegrationSpec `json:"spec"` | |||
| Status IntegrationStatus `json:"status,omitempty"` | |||
| Context string `json:"context,omitempty"` | |||
There was a problem hiding this comment.
This should be part of Spec according to Kubernetes conventions
pkg/apis/camel/v1alpha1/types.go
Outdated
|
|
||
| const ( | ||
| // IntegrationContextPhaseEditing -- | ||
| IntegrationContextPhaseEditing IntegrationContextPhase = "Editing" |
There was a problem hiding this comment.
Is this a real status? Like "Draft"?
There was a problem hiding this comment.
Yes, renamed it to draft to make it more clear
pkg/client/cmd/context_edit.go
Outdated
| } | ||
|
|
||
| cmd.Flags().BoolVarP(&impl.discard, "discard", "x", false, "Discard current edit session") | ||
| cmd.Flags().BoolVarP(&impl.save, "save", "s", false, "Save edit session") |
There was a problem hiding this comment.
Doesn't seem you're opening a session (I hope you're not), it's a patch like action.
There was a problem hiding this comment.
Behavior changed so the context is saved by default, if you want to edit the context using multiple commands, set --save=false
pkg/stub/action/context/monitor.go
Outdated
| } | ||
|
|
||
| func (action *integrationContexMonitorAction) Name() string { | ||
| return "Edit" |
There was a problem hiding this comment.
Ok they're named the same but it's everything todo
lburgazzoli
force-pushed
the
integration-context
branch
from
7fe398f
to
7468235
Compare
lburgazzoli
force-pushed
the
integration-context
branch
from
7468235
to
e303acf
Compare
zach-robinson
pushed a commit
to zach-robinson/camel-k
that referenced
this pull request
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.