-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial code for integration context #24
Conversation
3ca3900
to
39c5668
Compare
c3f3f54
to
7fe398f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. Just few minor issues.
Remember to add docs when you add the final version 😄 !
Gopkg.lock
Outdated
@@ -2,230 +2,179 @@ | |||
|
|||
|
|||
[[projects]] | |||
digest = "1:5c3894b2aa4d6bead0ceeea6831b305d62879c871780e7b76296ded1b004bc57" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move to "dep 0.5.0"?
pkg/apis/camel/v1alpha1/types.go
Outdated
@@ -36,6 +36,7 @@ type Integration struct { | |||
metav1.ObjectMeta `json:"metadata"` | |||
Spec IntegrationSpec `json:"spec"` | |||
Status IntegrationStatus `json:"status,omitempty"` | |||
Context string `json:"context,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be part of Spec
according to Kubernetes conventions
pkg/apis/camel/v1alpha1/types.go
Outdated
|
||
const ( | ||
// IntegrationContextPhaseEditing -- | ||
IntegrationContextPhaseEditing IntegrationContextPhase = "Editing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a real status? Like "Draft"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, renamed it to draft to make it more clear
pkg/client/cmd/context_edit.go
Outdated
} | ||
|
||
cmd.Flags().BoolVarP(&impl.discard, "discard", "x", false, "Discard current edit session") | ||
cmd.Flags().BoolVarP(&impl.save, "save", "s", false, "Save edit session") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem you're opening a session (I hope you're not), it's a patch like action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Behavior changed so the context is saved by default, if you want to edit the context using multiple commands, set --save=false
pkg/stub/action/context/monitor.go
Outdated
} | ||
|
||
func (action *integrationContexMonitorAction) Name() string { | ||
return "Edit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok they're named the same but it's everything todo
7fe398f
to
7468235
Compare
7468235
to
e303acf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
No description provided.