fix(trait): never fallback to client-side apply unless server-side apply is incombatible #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jun 21, 2021
astefanutti
reviewed
Jun 21, 2021
tadayosi
force-pushed
the
log-before-fallback-csa
branch
from
1193cf4
to
2a60184
Compare
tadayosi
changed the title
astefanutti
approved these changes
Jun 21, 2021
|
That fails on OpenShift 3. It seems the current |
…ply is incombatible CSA support is mainly kept for compatibility reason and will ultimately be removed, so it should only be used as fallback when SSA is known to be unavailable.
tadayosi
force-pushed
the
log-before-fallback-csa
branch
from
2a60184
to
9c5ee25
Compare
astefanutti
approved these changes
Jun 22, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's convenient for debugging if we output log with error why SSA failed at deployer trait (other than incompatibility) before attempting to CSA so that we can know the direct reason why the operation failed.
Release Note