Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync main with the latest changes from camel-main #2426

Merged
merged 15 commits into from
Jun 23, 2021

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented Jun 22, 2021

This essentially brings to main, the changes from camel-main that enabled Camel Quarkus 2.0.0 and Camel 3.10.

Please do a thorough review of the changes, as there were conflicts that had to be manually resolved.

Release Note

Updates to Camel Quarkus 2.x
Updates to Camel 3.10

@orpiske
Copy link
Contributor Author

orpiske commented Jun 22, 2021

@astefanutti @lburgazzoli @nicolaferraro Some your changes had to be manually resolved due to conflicts. Therefore I marked all of you as a reviewer.

@lburgazzoli
Copy link
Contributor

LGTM

@orpiske orpiske marked this pull request as ready for review June 22, 2021 12:45
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Is the Knative issue fixed elsewhere?

@nicolaferraro
Copy link
Member

The Knative issue seems an error in the Yaks test, maybe the binding used there is not up to date

Fixed kamelets format as suggested by Nicola

Co-authored-by: Nicola Ferraro <ni.ferraro@gmail.com>
@orpiske
Copy link
Contributor Author

orpiske commented Jun 23, 2021

Thanks everyone for the review and comments! So I think there's plenty of +1s for this ... I plan to merge this today at morning, in a few hours. There's still time for more comments/reviews in case anyone finds something.

@orpiske orpiske merged commit 5d2f799 into apache:main Jun 23, 2021
@nicolaferraro nicolaferraro mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants