Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(architecture): trait section #2465

Merged
merged 2 commits into from
Jul 1, 2021
Merged

doc(architecture): trait section #2465

merged 2 commits into from
Jul 1, 2021

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Jun 29, 2021

Ref #2273

Release Note

NONE

@squakez
Copy link
Contributor Author

squakez commented Jun 29, 2021

@astefanutti @nicolaferraro I'd like your review to confirm that the document explaining traits is accurate enough. Thanks!

@astefanutti astefanutti added the area/documentation Documentation task label Jun 29, 2021
@squakez
Copy link
Contributor Author

squakez commented Jun 30, 2021

Thanks @astefanutti @tadayosi, I've adjusted following your suggestions. Please, have a further look.

@tadayosi
Copy link
Member

@squakez LGTM. Thanks!

docs/modules/ROOT/pages/architecture/traits.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/architecture/traits.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/architecture/traits.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/architecture/traits.adoc Outdated Show resolved Hide resolved
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

@astefanutti astefanutti merged commit bf213e7 into apache:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants