Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd/run): windows scheme support #2477

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Jul 1, 2021

Introduced a check to verify if the source matches with a supported scheme.

Closes #2475

Release Note

fix(cmd/run): windows scheme support

Introduced a check to verify if the source matches with a supported scheme.

Closes apache#2475
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. When I read Windows I have the chills.

@squakez
Copy link
Contributor Author

squakez commented Jul 1, 2021

Looks good to me. When I read Windows I have the chills.
🤣

@nicolaferraro nicolaferraro merged commit 19516e0 into apache:main Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cmd] kamel run github|http|... fails on windows machine
3 participants