Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): kamel uninstall should delete kamelets #2479 #2489

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

tadayosi
Copy link
Member

@tadayosi tadayosi commented Jul 9, 2021

Fix #2479

Release Note

`kamel uninstall` now also cleans up all kamelets defined in the same namespace.

@lburgazzoli
Copy link
Contributor

@nicolaferraro @tadayosi wonder if we should delete all the kamelets or only those that have been installed as part of the operator installation as the user may have installed its own set of kamelets that I guess, should not be deleted as part of the uninstall process

@tadayosi
Copy link
Member Author

tadayosi commented Jul 9, 2021

@lburgazzoli FYI this pull req also introduces --skip-kamelets option. Maybe we can activate the option by default or introduce another option --skip-user-kamelets with true by default.

@tadayosi
Copy link
Member Author

tadayosi commented Jul 9, 2021

Reconsidering it, now I think it's better for kamel uninstall to keep user-defined kamelets untouched whether or not --skip-kamelets is enabled, rather than erasing them altogether as Luca suggests. Users can manage your own set of kamelets with kamel kamelet subcommands.

@tadayosi tadayosi force-pushed the Issue-2479-uninstall-kamelets branch from b0deeb7 to 96c9d6c Compare July 13, 2021 05:57
@tadayosi tadayosi force-pushed the Issue-2479-uninstall-kamelets branch from 96c9d6c to bdfc551 Compare July 13, 2021 07:05
@nicolaferraro nicolaferraro merged commit fd7cb09 into apache:main Jul 16, 2021
@nicolaferraro nicolaferraro mentioned this pull request Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kamel uninstall should delete kamelets
3 participants