[test] add Kamelet errorHandler test

[bouskaJ]

Release Note

NONE

[squakez]

It's a very good PR that includes the Kamelet creation support! There are a few changes that would make it more reusable, feel free to follow those suggestions and if you have any further doubt I will be happy to help.

[bouskaJ]

@squakez, @astefanutti the CI fails with

 logs:
Error:     dump.go:142:     integration
Error:     dump.go:174:     > 	at org.apache.camel.reifier.RouteReifier.doCreateRoute(RouteReifier.java:236)
Error:     dump.go:174:     > 	... 31 more
Error:     dump.go:174:     > 
Error:     dump.go:174:     > 2021-07-23 11:25:32,186 ERROR [io.qua.run.Application] (main) Failed to start application (with profile prod): org.apache.camel.NoSuchBeanException: No bean could be found in the registry for:  defaultErrorHandler of type: org.apache.camel.ErrorHandlerFactory
Error:     dump.go:174:     > 	at org.apache.camel.support.CamelContextHelper.mandatoryLookup(CamelContextHelper.java:241)
Error:     dump.go:174:     > 	at org.apache.camel.model.errorhandler.ErrorHandlerHelper.lookupErrorHandlerFactory(ErrorHandlerHelper.java:82)
Error:     dump.go:174:     > 	at org.apache.camel.reifier.errorhandler.ErrorHandlerRefReifier.lookupErrorHandler(ErrorHandlerRefReifier.java:41)
Error:     dump.go:174:     > 	at org.apache.camel.reifier.errorhandler.ErrorHandlerRefReifier.createErrorHandler(ErrorHandlerRefReifier.java:35)

the generated KameletBinding is

spec:
  errorHandler:
    dead-letter-channel:
      endpoint:
        properties:
          loggerName: kameletErrorHandler
        ref:
          apiVersion: camel.apache.org/v1alpha1
          kind: Kamelet
          name: my-own-log-sink
  sink:
    properties:
      loggerName: integrationLogger
    ref:
      apiVersion: camel.apache.org/v1alpha1
      kind: Kamelet
      name: my-own-log-sink
  source:
    properties:
      message: throw Error
    ref:
      apiVersion: camel.apache.org/v1alpha1
      kind: Kamelet
      name: my-own-error-producer-source

   spec:
          configuration:
          - type: property
            value: 'camel.beans.defaultErrorHandler = #class:org.apache.camel.builder.DeadLetterChannelBuilder'
          - type: property
            value: camel.beans.defaultErrorHandler.deadLetterUri = kamelet:my-own-log-sink/errorHandler
          - type: property
            value: camel.k.errorHandler.ref = defaultErrorHandler
          - type: property
            value: camel.kamelet.my-own-error-producer-source.source.message = throw Error
          - type: property
            value: camel.kamelet.my-own-log-sink.errorHandler.loggerName = kameletErrorHandler
          - type: property
            value: camel.kamelet.my-own-log-sink.sink.loggerName = integrationLogger
          flows:
          - from:
              steps:
              - to: kamelet:my-own-log-sink/sink
              uri: kamelet:my-own-error-producer-source/source
          profile: OpenShift

The most important message is that the test is working on 1.4.0. Do you know what could be wrong?

[squakez]

Yeah, I bumped into that issue as well while working on something different. I am investigating and will report more details shortly.

[squakez]

Tracked here #2525

[squakez]

Let's wait to merge #2564 and we can rebase this.

[mcada]

#2564 is merged - can we proceed with the rebase?

[squakez]

#2564 is merged - can we proceed with the rebase?

Yes please.

[bouskaJ]

@squakez Two CI workflows failed but it seems that it's not my fault. Can you rerun them?

[squakez]

I think this one should be optional. If you provide some meaningful configuration, then you can provide the ErrorHandler parameter, otherwise you must not. The error reported in the CI may be because of this configuration that likely is set to empty.