-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Probe Scheme to Be Customized #2527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
@Kyle-Cooley do you think you can include that simple example under trait/container example directory (it has to be created)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please run make generate-doc
to reflect the changes into the documentation?
I've made those changes. Let me know if there is anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks a lot!
Addresses #2513. This change allows the scheme used for the liveness and readiness probes to be overridden to HTTPS when needed. The approach taken was minimalistic.
Verified using this groovy script saved to /tmp/helloworld.groovy
and an integration deployed with the following commands
Release Note