Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2486: make kamelet binding scalable #2582

Merged
merged 4 commits into from
Aug 23, 2021

Conversation

nicolaferraro
Copy link
Member

Fix #2486

Release Note

KameletBinding resources are now scalable

@nicolaferraro nicolaferraro added the kind/feature New feature or request label Aug 18, 2021
Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@astefanutti
Copy link
Member

A quick Scaling > Kamelet documentation entry could be worth it, along with the exiting integration scaling documentation:

https://camel.apache.org/camel-k/latest/scaling/integration.html

@nicolaferraro
Copy link
Member Author

A quick Scaling > Kamelet documentation entry could be worth it, along with the exiting integration scaling documentation:

https://camel.apache.org/camel-k/latest/scaling/integration.html

Sure, I can add it.

Any idea of what's happening? I'm unable to replicate on minikube. For some reason a simple (full) replace with only the "replicas" field chaned fails in the test...

@astefanutti
Copy link
Member

Any idea of what's happening? I'm unable to replicate on minikube. For some reason a simple (full) replace with only the "replicas" field chaned fails in the test...

Hum, I would suspect the test client schema is not setup correctly somehow, possibly the KameletBinding type is not registered correctly... But I cannot find anything obvious :(

@nicolaferraro
Copy link
Member Author

nicolaferraro commented Aug 19, 2021

Any idea of what's happening? I'm unable to replicate on minikube. For some reason a simple (full) replace with only the "replicas" field chaned fails in the test...

Hum, I would suspect the test client schema is not setup correctly somehow, possibly the KameletBinding type is not registered correctly... But I cannot find anything obvious :(

Yeah, I've regenerated everything and I've also managed to install the same kind version, but nothing. I'd think to a transient error if that didn't happen on openshift (3.11) as well..

@astefanutti
Copy link
Member

Yeah, I've regenerated everything and I've also managed to install the same kind version, but nothing. I'd think to a transient error if that didn't happen on openshift (3.11) as well..

Yes, it's very strange since it's the exact same logic used for the integration scaling tests... I wonder if there is nothing specific about the way we initialise the test client, but I don't see anything obvious...

@astefanutti
Copy link
Member

I wonder if there is something going on with the fast mapper thing, with a group having multiple versions...

@nicolaferraro
Copy link
Member Author

I wonder if there is something going on with the fast mapper thing, with a group having multiple versions...

mmh, disabled fastmapper in previous run.. same result..

@astefanutti
Copy link
Member

It may be TestClient().Get(TestContext, key, &klb) updates the klb struct with an empty Kind for some reasons. That would explain why patching works, while update fails. Still, it is troublesome the Get call does not work for KameletBinding while it works for Integration...

@nicolaferraro nicolaferraro removed the status/wip Work in progress label Aug 23, 2021
@astefanutti astefanutti merged commit eac1eea into apache:main Aug 23, 2021
@nicolaferraro nicolaferraro mentioned this pull request Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kamelet binding: make it scalable ?
4 participants