Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output redirection Fix: #2495 #2656

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Output redirection Fix: #2495 #2656

merged 2 commits into from
Sep 24, 2021

Conversation

vsokolovskii
Copy link
Contributor

@vsokolovskii vsokolovskii commented Sep 23, 2021 •
edited by squakez
Loading

Fix: #2495

@vsokolovskii
Copy link
Contributor Author

@squakez job failure isn't caused by my changes I believe

squakez
squakez reviewed Sep 23, 2021
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, thanks! Just a few comments to understand a couple of points.

pkg/cmd/describe_platform.go Show resolved Hide resolved
pkg/cmd/dump.go Show resolved Hide resolved
astefanutti
astefanutti reviewed Sep 23, 2021
View reviewed changes
Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please run go fmt before to have it merged?

@vsokolovskii
Copy link
Contributor Author

Could you please run go fmt before to have it merged?

gofmt format changes were applied

@vsokolovskii
Copy link
Contributor Author

job failures aren't caused by the changes

@astefanutti astefanutti merged commit 05856a6 into apache:main Sep 24, 2021
@astefanutti
Copy link
Member

Thanks!

@vsokolovskii vsokolovskii deleted the output-redirection branch September 24, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti left review comments

@squakez squakez squakez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kamel cli output redirection doesn't work for some commands
3 participants
@vsokolovskii @astefanutti @squakez