Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Missing cli tests were added #2680

Merged
merged 4 commits into from
Oct 18, 2021
Merged

[TEST] Missing cli tests were added #2680

merged 4 commits into from
Oct 18, 2021

Conversation

vsokolovskii
Copy link
Contributor

@vsokolovskii vsokolovskii commented Oct 5, 2021

go fmt was executed against the changes
Once it is merged -> PR #2176 can be closed also

@vsokolovskii vsokolovskii changed the title Missing cli tests were added [TEST] Missing cli tests were added Oct 5, 2021
@vsokolovskii
Copy link
Contributor Author

vsokolovskii commented Oct 5, 2021

The failure isn't caused by the changes, please run the job again :) @oscerd

@squakez
Copy link
Contributor

squakez commented Oct 7, 2021

The failure isn't caused by the changes, please run the job again :) @oscerd

@vsokolov00 it seems the changes are the cause of the failure, please check the log for more info:

 --- FAIL: TestKamelCLIDump (0.38s)
    --- FAIL: TestKamelCLIDump/dump_empty_namespace (0.24s)

@astefanutti astefanutti merged commit 0aa37b4 into apache:main Oct 18, 2021
@astefanutti
Copy link
Member

Thanks!

@vsokolovskii vsokolovskii deleted the missing-cli-tests branch October 18, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants