Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): disable object truncation on test results #2745

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

tadayosi
Copy link
Member

Relates to #2742

Release Note

NONE

@tadayosi
Copy link
Member Author

tadayosi commented Nov 11, 2021

Now it shows where the mismatch is:

=== RUN   TestMetrics/reconciliation_duration_metric
    operator_metrics_test.go:256: 
        Expected
            <string>: MetricFamily
        to match fields: {
        .Metric:
        	Expected
...
        	            Histogram: {
        	                SampleCount: 272,
...
        	to contain element matching
...
        	                "Histogram": <*gstruct.PointerMatcher | 0xc00061c140>{
        	                    Matcher: <*gstruct.FieldsMatcher | 0xc000add1d0>{
        	                        Fields: {
        	                            "SampleCount": <*gstruct.PointerMatcher | 0xc00061c120>{
        	                                Matcher: <*matchers.EqualMatcher | 0xc000c660a0>{Expected: <uint64>12},
        	                                failure: "Expected\n    <uint64>: 272\nto equal\n    <uint64>: 12",
        	                            },
        	                        },

What a difference! 😃
SampleCount: 272 != 12

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tadayosi tadayosi merged commit bbb3c4a into apache:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants