Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trait: add a trait to inject pod metadata as env var #276

Merged
merged 1 commit into from Dec 11, 2018
Merged

trait: add a trait to inject pod metadata as env var #276

merged 1 commit into from Dec 11, 2018

Conversation

lburgazzoli
Copy link
Contributor

Fixes #275

nicolaferraro
nicolaferraro requested changes Dec 11, 2018
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not calling it just "NAMESPACE", it's the convention used also in other tools like 'fmp'.

@lburgazzoli
Copy link
Contributor Author

should I rename also POD_NAME to NAME ?

@nicolaferraro
Copy link
Member

No, I'm not aware of any convention for it...

@lburgazzoli
Copy link
Contributor Author

@nicolaferraro done

@nicolaferraro nicolaferraro merged commit 3c82efe into apache:master Dec 11, 2018
@lburgazzoli lburgazzoli deleted the github-275-env branch December 11, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lburgazzoli @nicolaferraro @oscerd