Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): default jitpack to main #2775

Merged
merged 1 commit into from
Nov 25, 2021
Merged

fix(build): default jitpack to main #2775

merged 1 commit into from
Nov 25, 2021

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Nov 23, 2021 •
edited
Loading

  • Moved default from master to main
  • Added some meaningful example

Closes #2764

Release Note

fix(build): default jitpack to main

tadayosi
tadayosi approved these changes Nov 24, 2021
View reviewed changes
pkg/util/jitpack/jitpack.go Outdated Show resolved Hide resolved
@squakez
fix(build): default jitpack to main
5fa16aa 
* Moved default from master to main
* Added some meaningful example

Closes apache#2764
astefanutti
astefanutti approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@squakez
Copy link
Contributor Author

squakez commented Nov 24, 2021

CI is failing because #2742 not related to the change done here. I'll merge if no objections.

@squakez squakez merged commit fef0e61 into apache:main Nov 25, 2021
@squakez squakez deleted the fix/2764_jitpack_default branch November 25, 2021 09:15
@oscerd oscerd mentioned this pull request Jan 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadayosi tadayosi tadayosi approved these changes

@astefanutti astefanutti astefanutti approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jitpack still configured with master branch
4 participants
@squakez @tadayosi @astefanutti @oscerd