Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint #2780

Merged
merged 6 commits into from
Nov 25, 2021
Merged

lint #2780

merged 6 commits into from
Nov 25, 2021

Conversation

lburgazzoli
Copy link
Contributor

Release Note

NONE

@lburgazzoli lburgazzoli marked this pull request as draft November 24, 2021 13:48
@lburgazzoli lburgazzoli changed the title fix(lint): net/http.Get must not be called (noctx) lint Nov 24, 2021
@lburgazzoli lburgazzoli marked this pull request as ready for review November 24, 2021 15:02
@lburgazzoli
Copy link
Contributor Author

@astefanutti enabled and fixed some more linters

astefanutti
astefanutti reviewed Nov 24, 2021
View reviewed changes
pkg/cmd/run_help.go Outdated Show resolved Hide resolved
astefanutti
astefanutti approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@astefanutti astefanutti merged commit bb51a99 into apache:main Nov 25, 2021
@lburgazzoli lburgazzoli deleted the noctx branch November 25, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lburgazzoli @astefanutti @oscerd