Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global test on ns with its own op fix #2784

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

vitorz
Copy link

@vitorz vitorz commented Nov 25, 2021

Fix an issue of e2e/global_test/Global_test_on_namespace_with_its_own_operator which relied to the default ck operator image using "--olm=false" flag value

Release Note

NONE

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't refer to downstream issue number in commit message or PR title

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few validation errors as well. Pls fix them accordingly.

@vitorz
Copy link
Author

vitorz commented Nov 26, 2021

There are a few validation errors as well. Pls fix them accordingly.

done

@vitorz vitorz closed this Nov 26, 2021
@vitorz
Copy link
Author

vitorz commented Nov 26, 2021

sorry, closed by mistake. Now reopened

@vitorz vitorz reopened this Nov 26, 2021
@claudio4j
Copy link
Contributor

@vitorz Can you rebase this PR ?

@vitorz vitorz force-pushed the global_test_on_ns_with_its_own_op_fix branch from 2ebd5ca to a32b931 Compare January 13, 2022 09:29
@vitorz
Copy link
Author

vitorz commented Jan 13, 2022

@claudio4j i rebased the PR

@claudio4j
Copy link
Contributor

Was able to run test with a custom image, it works, thanks.

@squakez
Copy link
Contributor

squakez commented Mar 11, 2022

@vitorz could you please rebase this PR? cannot merge because a conflict. Thanks.

@vitorz vitorz force-pushed the global_test_on_ns_with_its_own_op_fix branch from a32b931 to cccbb54 Compare March 15, 2022 16:42
@vitorz
Copy link
Author

vitorz commented Mar 15, 2022

@squakez i rebased

@squakez
Copy link
Contributor

squakez commented Apr 1, 2022

Merging after the changes applied as required by reviewers. FYI @oscerd @tadayosi

@squakez squakez merged commit 566ed30 into apache:main Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants