-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] - check IntegrationPlatform namespace with global operator #2895
Conversation
CI failures do not seem to be related to this PR. Can you rerun the CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Maybe the IntegrationPlatform condition could be retrieved using the idiomatic WithTransform
and the condition type as parameter.
570b78d
to
fb20e95
Compare
@astefanutti thank you for your review. I reworked it using existing functions. |
@bouskaJ perfect, looks great! |
@astefanutti do you know what's wrong with the CI? |
@bouskaJ some tests are failing because of the upgrade done for the new release. It's not related to your PR. We're going to have them fixed and you'll be able to rebase. |
fb20e95
to
b633eb4
Compare
Hi @astefanutti I have rebased this PR. The CI failed on various errors not related to this PR kuberenetes and openshift workflow:
upgrade:
Is there still some ongoing activity to fix that? |
@bouskaJ Thanks for the update.
This will be fixed with #2911.
I'm working on it. I've fixed it for branches with #2904, but it's not working for cross-channel upgrade in #2901. It seems the channel change does not trigger the upgrade. I'm still trying to understand what's going, maybe if you could have a look to check if I'm missing something obvious, that would be great. |
b633eb4
to
d13667e
Compare
@astefanutti all checks have passed. Thank you for your fixes. |
@bouskaJ great, thanks a lot for your patience. Let's merge it! |
Release Note