Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] - check IntegrationPlatform namespace with global operator #2895

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

bouskaJ
Copy link
Contributor

@bouskaJ bouskaJ commented Jan 20, 2022

Release Note

NONE

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Jan 20, 2022

CI failures do not seem to be related to this PR. Can you rerun the CI?

Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Maybe the IntegrationPlatform condition could be retrieved using the idiomatic WithTransform and the condition type as parameter.

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Jan 21, 2022

@astefanutti thank you for your review. I reworked it using existing functions.

@astefanutti
Copy link
Member

@bouskaJ perfect, looks great!

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Jan 21, 2022

@astefanutti do you know what's wrong with the CI?

@astefanutti
Copy link
Member

@bouskaJ some tests are failing because of the upgrade done for the new release. It's not related to your PR. We're going to have them fixed and you'll be able to rebase.

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Jan 24, 2022

Hi @astefanutti I have rebased this PR. The CI failed on various errors not related to this PR

kuberenetes and openshift workflow:

=== RUN   TestHealthTrait/Readiness_condition_with_stopped_route
Integration "java" created
=== CONT  TestHealthTrait
    health_test.go:77: 
        Timed out after 60.001s.
        Expected
            <string>: "...p[consumer:..."
        to equal               |
            <string>: "...p[context:U..."
=== CONT  TestHealthTrait/Readiness_condition_with_stopped_route

upgrade:

1 integrations have been rebuilt
=== CONT  TestOLMAutomaticUpgrade
    olm_upgrade_test.go:166: 
        Timed out after 60.027s.
        Expected
            <string>: 
        to contain substring
            <string>: 1.8
=== CONT  TestOLMAutomaticUpgrade/Integration_upgrade

Is there still some ongoing activity to fix that?

@astefanutti
Copy link
Member

Hi @astefanutti I have rebased this PR. The CI failed on various errors not related to this PR

@bouskaJ Thanks for the update.

kuberenetes and openshift workflow:

=== RUN   TestHealthTrait/Readiness_condition_with_stopped_route
Integration "java" created
=== CONT  TestHealthTrait
    health_test.go:77: 
        Timed out after 60.001s.
        Expected
            <string>: "...p[consumer:..."
        to equal               |
            <string>: "...p[context:U..."
=== CONT  TestHealthTrait/Readiness_condition_with_stopped_route

This will be fixed with #2911.

upgrade:

1 integrations have been rebuilt
=== CONT  TestOLMAutomaticUpgrade
    olm_upgrade_test.go:166: 
        Timed out after 60.027s.
        Expected
            <string>: 
        to contain substring
            <string>: 1.8
=== CONT  TestOLMAutomaticUpgrade/Integration_upgrade

Is there still some ongoing activity to fix that?

I'm working on it. I've fixed it for branches with #2904, but it's not working for cross-channel upgrade in #2901. It seems the channel change does not trigger the upgrade. I'm still trying to understand what's going, maybe if you could have a look to check if I'm missing something obvious, that would be great.

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Jan 26, 2022

@astefanutti all checks have passed. Thank you for your fixes.

@astefanutti
Copy link
Member

@bouskaJ great, thanks a lot for your patience. Let's merge it!

@astefanutti astefanutti merged commit ce98aff into apache:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants