Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(knative): Rely on addressable-resolver ClusterRole to transfer RBAC for Knative Sinks #2958

Merged
merged 9 commits into from
Jan 31, 2022

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Jan 28, 2022

This PR removes the hard-coded set of resources that can be used as Knative Sinks, and instead binds the Knative addressable-resolver ClusterRole, that aggregates the Addressable resources that are available, so that the required permissions to resolve Knative Sink URLs are automatically transferred to the Camel K operator ServiceAccount.

Fixes #2950.

Release Note

feat(knative): Rely on addressable-resolver ClusterRole to transfer RBAC for Knative Sinks

@astefanutti astefanutti merged commit d1ce2cb into apache:main Jan 31, 2022
@astefanutti astefanutti deleted the pr-390 branch January 31, 2022 13:23
@pierDipi
Copy link

Thanks for the quick fix @astefanutti !!

@astefanutti
Copy link
Member Author

@pierDipi thank you for the addressable-resolver ClusterRole tip 👍🏼. That's quite an elegant pattern for other controllers to integrate with Knative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/knative Related to Knative kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

camel-k-operator forbidden to get kafkachannels.messaging.knative.dev since 1.8.x
3 participants