Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): incremental build #3008

Merged
merged 2 commits into from
Feb 15, 2022
Merged

fix(build): incremental build #3008

merged 2 commits into from
Feb 15, 2022

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Feb 11, 2022

  • Fixed the SHA1 which were not calculated properly
  • Unit and E2E test to make sure we'll be warned if the behavior is broken again

Closes #3007

Release Note

fix(build): incremental build

pkg/builder/image.go Outdated Show resolved Hide resolved
* Fixed the SHA1 which were not calculated properly
* Unit and E2E test to make sure we'll be warned if the behavior is broken again

Closes apache#3007
@squakez
Copy link
Contributor Author

squakez commented Feb 15, 2022

This one looks good now. @astefanutti do you think is it okey to merge (given that we will need to come back on this topic with #3011)?

Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I agree adding the option to switch incremental image build off can be added later on.

@astefanutti astefanutti merged commit 1438ee0 into apache:main Feb 15, 2022
@squakez squakez deleted the fix/sha1 branch February 15, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build artifact checksum not working
3 participants