Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The error handler trait should update status dependencies #3056

Merged
merged 1 commit into from
Mar 2, 2022
Merged

fix: The error handler trait should update status dependencies #3056

merged 1 commit into from
Mar 2, 2022

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Mar 1, 2022

This affects the Integration digest, which causes infinite ping-pong between the Initialization and Building Kit phases.

Generally, the operator is forbidden to update the user-land .spec section, which makes the current code bad design, in addition to being broken.

Release Note

fix: The error handler trait should update status dependencies

@lburgazzoli
Copy link
Contributor

@oscerd this seems to be a very critical issue, we probably need a new release

@oscerd
Copy link
Contributor

oscerd commented Mar 1, 2022

Does this affect also 1.8.x?

@lburgazzoli
Copy link
Contributor

Does this affect also 1.8.x?

yes

@oscerd
Copy link
Contributor

oscerd commented Mar 1, 2022

It should be a bit more faster then the 1.8.1. I'll try to release soon.

@astefanutti
Copy link
Member Author

astefanutti commented Mar 2, 2022

Let's merge this, and have it back ported to 1.8.x, as the upgrade and openshift workflows failures are not related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants