Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Add kamel debug test #3131

Merged
merged 1 commit into from
Jul 14, 2022
Merged

[TEST] Add kamel debug test #3131

merged 1 commit into from
Jul 14, 2022

Conversation

bouskaJ
Copy link
Contributor

@bouskaJ bouskaJ commented Mar 22, 2022

[TEST] Add kamel debug test

Release Note

NONE

e2e/common/cli/debug_test.go Outdated Show resolved Hide resolved
@squakez
Copy link
Contributor

squakez commented Apr 12, 2022

Test failing:

    --- FAIL: TestKamelCLIDebug/debug_local_port_check (300.35s)

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Apr 19, 2022

Test failing:

    --- FAIL: TestKamelCLIDebug/debug_local_port_check (300.35s)

Yes, I know about that. It seems that the test is fluky with the CI (it's quite stable locally). Let's keep this PR open. I will try to resolve it when I will have time.

@tadayosi
Copy link
Member

tadayosi commented Jul 8, 2022

@bouskaJ It's still worth merging. Can you just rebase it and rerun the checks? Recently we stabilised CI so just rebasing could make it pass all.

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update, but we recently restructured e2e tests and now this test should be at e2e/global/common/debug_test.go. Please change the file path.

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Jul 13, 2022

Thanks for update, but we recently restructured e2e tests and now this test should be at e2e/global/common/debug_test.go. Please change the file path.

Hi @tadayosi thank you for your comment. I think this test should be in the same directory as other cli commands so I moved it to e2e/namespace/install/cli/debug_test.go

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tadayosi tadayosi merged commit 88ebd00 into apache:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants