-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled deprecated linters on golangci-lint #3139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gre8t thanks, that looks good, could you please remove that extra merge commit?
Looks good, but please rebase. |
Alright. Thank you for the feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recently there was an effort to keep the linters in alphabetical order. Please try to follow that pattern as well.
Hi, I have being stuck in how to rebase and at the same time remove the merge commit |
You just need to remove commit 9e38a6d, which you should be able to do with |
@Gre8t Just for a tip, I'd always create a different branch for submitting a pull req:
then rebasing the latest
After that you can force-push the branch to your repo:
|
.golangci.yml
Outdated
- testpackage | ||
- varnamelen | ||
- whitespace | ||
- wrapcheck | ||
- wsl | ||
- interfacer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is provided twice, you should remove from this line
.golangci.yml
Outdated
@@ -40,6 +40,8 @@ linters: | |||
- gofumpt | |||
- gomnd | |||
- gomoddirectives | |||
- golint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golint
should be put before gomnd
Thank you everyone for your help. I have implemented the corrections in pr #3158. Is it ok to close this pr? |
I had to disable the linters to fix the warning in #3012. We already have an "enable-all" in the linters' section of the config file set to true, then the recommended linters for deprecated are all enabled.
Release Note