added trait example of services #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gre8t
changed the title
|
I want to add this example to the docs-module-service folder. |
tadayosi
requested changes
Apr 4, 2022
squakez
reviewed
Apr 4, 2022
squakez
reviewed
Apr 5, 2022
There was a problem hiding this comment.
Thanks, I think it is going in the right direction. What we miss now is some further step to explain how to call that service. Ie, you can think another route calling it. We need also to provide some readme.md to provide the step by step procedure to run the example.
|
can you make a review @astefanutti |
tadayosi
approved these changes
Apr 11, 2022
|
@squakez please review |
tadayosi
approved these changes
Apr 18, 2022
squakez
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #3147. It's an example of activating traits (services).
Release Note