operator: allow to configure the lock name #3163
Conversation
lburgazzoli
changed the title
|
Not sure if this is the right way to do it or even if that's the right way to solve it. |
| } | ||
|
|
||
| func (o *operatorCmdOptions) run(_ *cobra.Command, _ []string) { | ||
| operator.Run(o.HealthPort, o.MonitoringPort, o.LeaderElection) | ||
| operator.Run(o.HealthPort, o.MonitoringPort, o.LeaderElection, o.LeaderElectionID) |
There was a problem hiding this comment.
We need to check if that parameter exists, and, if not, fallback to platform.OperatorLockName (which I'd call at this stage as platform.OperatorDefaultLockName)
There was a problem hiding this comment.
This should already happen when the flag is initialized, by default it should be that value
|
@astefanutti @squakez do you think this can be merged or we should have some better way of dealing with it ? |
|
@lburgazzoli LGTM, +1 to have it merged. |
|
@lburgazzoli could you just make sure to regenerate the |
remind me how to re-genreate it |
That should be |
Done, I had to change the staging maven repo to https://repository.apache.org/content/repositories/orgapachecamel-1427 @oscerd is that correct ? |
|
Yes, there is another PR with that fix, but we could merge this one and we've done. |
|
Let's merge it so we can proceed with the release. |
Release Note
Fixes #3162