-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(olm): IntegrationPlatform reconciled by operator #3172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The annotation should probably be transported also here:
Line 118 in 7942108
defaultPlatform := v1.NewIntegrationPlatform(namespace, platformName) |
I've tried to cascade the annotation there, but I noticed that we cannot reach that point because we always get the IntegrationPlatform present in the operator namespace (see Line 104 in 7942108
|
Even when the operator is installed with OLM? |
I haven't tested that scenario. Let me check how it is affected in such case. |
3338e27
to
7d5617e
Compare
7d5617e
to
1303cf1
Compare
I've tested locally to confirm OLM behavior is fine. We'll need to include an automated E2E test for OLM installation once #3180 is ready. |
1303cf1
to
cf7b08f
Compare
Closes #3161
Release Note