Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing trait usage example #3184

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

SubhasmitaSw
Copy link
Contributor

fixes #3148

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Some minor notes to fix and additionally, is the examples/traits/tracing/.DS_Store needed for some reason?

examples/traits/tracing/README.md Outdated Show resolved Hide resolved
examples/traits/tracing/InventoryService.java Outdated Show resolved Hide resolved
examples/traits/tracing/OrderService.java Outdated Show resolved Hide resolved
examples/traits/tracing/OrderService.java Outdated Show resolved Hide resolved
examples/traits/tracing/README.md Outdated Show resolved Hide resolved
@SubhasmitaSw
Copy link
Contributor Author

SubhasmitaSw commented Apr 11, 2022

Excellent work! Some minor notes to fix and additionally, is the examples/traits/tracing/.DS_Store needed for some reason?

The .DS_Store file is some sort of automatic generated file, probably will get created when we run this integration to test. So I'll remove this, not specific to the main repo.

update
The option to delete the file is not active, also it's not tracked with any folder in my local repo. I'm not sure how to remove it.

@tadayosi
Copy link
Member

@SubhasmitaSw Use terminal and you can see it with ls -a. You can also remove it with:

git rm examples/traits/tracing/.DS_Store

then

git commit --amend

@SubhasmitaSw
Copy link
Contributor Author

@SubhasmitaSw Use terminal and you can see it with ls -a. You can also remove it with:

git rm examples/traits/tracing/.DS_Store

then

git commit --amend

@tadayosi Thanks, it worked!

@squakez squakez merged commit f0909bf into apache:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracing trait usage example
3 participants