chore: Improve extract Camel catalog script #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid breaking Makefile when Camel catalog staging repository is not available for some reason. In case catalog is empty just log a WARNING and continue with the build.
oscerd
approved these changes
Apr 19, 2022
squakez
reviewed
Apr 19, 2022
There was a problem hiding this comment.
I think that is a transient situation happening when the staging repo does not exist any longer (it had to be moved because of #3222). IMO we should instead verify that the repo does not exist any longer and fail fast, claiming to the user that the staging repo does not exist.
|
@squakez yes this is transient. as the staging repository is hardcoded in the Makefile the user will not be able to build though until the staging repository is fixed and Makefile is updated. The staged catalog is part of the Camel K repository as a checked in file so I thought ignoring and logging a WARNING is enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid breaking Makefile when Camel catalog staging repository (e.g. https://repository.apache.org/content/repositories/orgapachecamel-1425) is not available for some reason. In case catalog is empty just log a WARNING and continue with the build.
Release Note