Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logging traits documentation. #3231

Merged
merged 4 commits into from
May 10, 2022
Merged

Conversation

Gre8t
Copy link
Contributor

@Gre8t Gre8t commented Apr 24, 2022

The logging traits needed a documentation. This fixes issue #3143

Release Note

NONE

@Gre8t
Copy link
Contributor Author

Gre8t commented Apr 24, 2022

@astefanutti @squakez

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks.

examples/traits/logging/logging.java Outdated Show resolved Hide resolved
examples/traits/logging/loggingModeline.java Outdated Show resolved Hide resolved
examples/traits/logging/README.md Outdated Show resolved Hide resolved
@Gre8t Gre8t requested a review from squakez April 25, 2022 11:26
examples/traits/logging/Logging.java Outdated Show resolved Hide resolved
examples/traits/logging/README.md Outdated Show resolved Hide resolved
examples/traits/logging/README.md Outdated Show resolved Hide resolved
@Gre8t Gre8t requested a review from squakez April 27, 2022 06:44
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some change is needed


Logs are enabled by default on an integration. Just run this example:

$ kamel run logging.java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging with L uppercase...


$ kubectl get pods

$ kubecttl logs <pod name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably kubectl


manual log setting example using `logging trait`:

$ kamel run ./logging.java --trait logging.enabled=true --trait logging.json=true --trait logging.level=info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging with L

## Using modeline
An example of using a `modeline` to set the `logging traits` :

$ kamel run ./loggingModeline.java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoggingModeline with L

@squakez squakez merged commit 442c158 into apache:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants