-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cmd/trait): refactor cmd & trait packages #3279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use this opportunity to refactor the depracated and soon-to-become-deprecated fields.
Status: v1.IntegrationStatus{ | ||
Phase: v1.IntegrationPhaseDeploying, | ||
Spec: v1.IntegrationSpec{ | ||
Configuration: []v1.ConfigurationSpec{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is deprecated. We should use related traits instead.
Name: "integration-name", | ||
IntegrationKit: &v1.IntegrationKit{ | ||
Spec: v1.IntegrationKitSpec{ | ||
Configuration: []v1.ConfigurationSpec{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet deprecated, but it will be soon. Let's try to use traits instead.
}, | ||
Platform: &v1.IntegrationPlatform{ | ||
Spec: v1.IntegrationPlatformSpec{ | ||
Configuration: []v1.ConfigurationSpec{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet deprecated, but it will be soon. Let's try to use traits instead.
Status: v1.IntegrationStatus{ | ||
Phase: v1.IntegrationPhaseDeploying, | ||
Spec: v1.IntegrationSpec{ | ||
Configuration: []v1.ConfigurationSpec{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
Name: "integration-name", | ||
IntegrationKit: &v1.IntegrationKit{ | ||
Spec: v1.IntegrationKitSpec{ | ||
Configuration: []v1.ConfigurationSpec{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
}, | ||
Platform: &v1.IntegrationPlatform{ | ||
Spec: v1.IntegrationPlatformSpec{ | ||
Configuration: []v1.ConfigurationSpec{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@squakez Actually the tests in I think the best timing to remove those tests is when we finally remove the deprecated fields and related code. |
Moved test and helper functions to where they should be.
Release Note