Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding basic support for PodSecurityContext. #3330

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Adding basic support for PodSecurityContext. #3330

merged 2 commits into from
Jun 6, 2022

Conversation

ammachado
Copy link

Camel-K is ignoring the securityContext part of my pod template:

securityContext:
  supplementalGroups:
    - 666

Release Note

feat: added support to podtemplate.spec.securityContext

astefanutti
astefanutti approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Maybe squashing the reverting commit.

@ammachado ammachado force-pushed the security-context-supplemental-groups branch 11 times, most recently from 2b95a28 to 477656a Compare June 3, 2022 02:54
tadayosi
tadayosi requested changes Jun 3, 2022
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is great. There is just a minor change request. Thx!

e2e/common/traits/pod_test.go Outdated Show resolved Hide resolved
@ammachado ammachado force-pushed the security-context-supplemental-groups branch from 477656a to 1db371c Compare June 3, 2022 13:51
@ammachado ammachado mentioned this pull request Jun 3, 2022
Merged
@ammachado ammachado marked this pull request as draft June 3, 2022 22:29
@ammachado ammachado force-pushed the security-context-supplemental-groups branch from 002e172 to 91d9af5 Compare June 3, 2022 23:17
@ammachado
Copy link
Author

ammachado commented Jun 3, 2022 •
edited
Loading

The file docs/modules/ROOT/attachments/schema/integration-schema.json is generated? If it is, how do I generate it based on the changed I've made to the CRDs?

@ammachado ammachado marked this pull request as ready for review June 3, 2022 23:19
@ammachado ammachado requested a review from tadayosi June 3, 2022 23:20
tadayosi
tadayosi requested changes Jun 4, 2022
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again only one minor comment. otherwise it looks great to me.

@tadayosi
Copy link
Member

tadayosi commented Jun 4, 2022

and the test is still failing.

    pod_test.go:65: 
        Expected
            <[]int64 | len:0, cap:0>: nil
        not to be nil

@ammachado
Copy link
Author

I'm on a M1 Mac machine, I can't get past image building here. Looking for a solution...

tadayosi
tadayosi reviewed Jun 4, 2022
View reviewed changes
pkg/trait/pod_test.go Outdated Show resolved Hide resolved
@ammachado ammachado force-pushed the security-context-supplemental-groups branch from 0885134 to 8293be5 Compare June 4, 2022 23:26
@ammachado ammachado requested a review from tadayosi June 4, 2022 23:28
@tadayosi tadayosi merged commit dd048c4 into apache:main Jun 6, 2022
@ammachado ammachado deleted the security-context-supplemental-groups branch June 6, 2022 13:35
@ammachado
Copy link
Author

This can be backported to 1.9?

@squakez
Copy link
Contributor

squakez commented Jun 7, 2022

@ammachado yes please. You can cherry pick those commits and create a PR on release-1.9.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadayosi tadayosi tadayosi approved these changes

@astefanutti astefanutti astefanutti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ammachado @tadayosi @squakez @astefanutti