Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): tidy submodules and make their tests run in build #3386

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

tadayosi
Copy link
Member

@tadayosi tadayosi commented Jun 23, 2022

I found out that the tests under these 3 dirs are ignored during build and test:

  • pkg/apis/camel
  • pkg/client/camel
  • pkg/kamelet/repository

because they have their own go.mod module definitions.

This updated the module definitions and put them in the test process.

Release Note

NONE

@tadayosi tadayosi added area/build-operator Related to the internal image build operator area/test labels Jun 23, 2022
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am wondering if it makes sense to have them a different set of dependencies and why not using the base ones. @astefanutti do you know why they are structured this way?

@astefanutti
Copy link
Member

LGTM. I am wondering if it makes sense to have them a different set of dependencies and why not using the base ones. @astefanutti do you know why they are structured this way?

@squakez APIs and clients have their own modules, so consumers do not have to depend on the main operator module, which is rather internal and should not be depended on conceptually. I think that's an accepted best practice among the operators ecosystem.

@tadayosi tadayosi merged commit 53dc13e into apache:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-operator Related to the internal image build operator area/test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants