allow setting resources & securityContext in Helm Chart values #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I don't know much about helm I cannot check if it's ok or not. Can anyone review this? @squakez @phantomjinx |
tadayosi
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Assuming this PR is fine, I think it's good to go ahead and merge it.
@squakez @phantomjinx Any objections?
|
Not familiar with Helm charts, hopefully @phantomjinx can have a look. |
oscerd
requested changes
Jul 14, 2022
| @@ -79,6 +79,8 @@ Camel K chart and their default values. The chart allows configuration of an `In | |||
| | `platform.build.registry.insecure` | Indicates if the registry is not secured | true | | |||
| | `platform.cluster` | The kind of Kubernetes cluster (Kubernetes or OpenShift) | `Kubernetes` | | |||
| | `platform.profile` | The trait profile to use (Knative, Kubernetes or OpenShift) | auto | | |||
| | `operator.resources` | the resource requests and limits to use for the operator | | | |||
| | `operator.securityContext` | The (container-related) securityContext to use for the operato | | | |||
oscerd
approved these changes
Aug 3, 2022
|
Let's merge for 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one of the best practices for operating workloads in Kubernetes is to set resource requests and limits as well as securityContext related settings.
This PR introduces the possibility to set those resource requests and limits as well as securityContext related settings. Since the exact settings cant be known and depend on the environment as well as the number and complexity of camel routes, users will be able to freely define their settings in the
values.yaml.Release Note