builder: add hooks to the builder state changes to update resources when the build completes #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jan 18, 2019
lburgazzoli
force-pushed
the
builder-state-handler
branch
from
59bb5c3
to
7ba65b0
Compare
…hen the build completes
lburgazzoli
force-pushed
the
builder-state-handler
branch
from
7ba65b0
to
c77a92d
Compare
oscerd
approved these changes
Jan 21, 2019
ipolyzos
pushed a commit
to ipolyzos/camel-k
that referenced
this pull request
Jul 31, 2019
…hen the build completes (apache#343)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I have refactored the builder so we can add event handlers and
react to build state changes. This make it possible - as example - to perform
resources updates as latest step of the build process avoiding incnsistent
contexts when the incremental builder search for compatible images