chore(contributing.adoc): Add explanation to add KOTLIN_JDK_HOME for building on MacOs #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jan 21, 2019
lburgazzoli
reviewed
Jan 21, 2019
contributing.adoc
Outdated
| @@ -72,6 +72,16 @@ make dep | |||
|
|
|||
| The `make dep` command runs `dep ensure -v` under the hood, so make sure that `dep` is properly installed. | |||
|
|
|||
| On MacOS and Windows you have to set the environment variable `KOTLIN_JDK_HOME` pointing to your JDK (not JRE) home directory. | |||
|
can we you squash the commits ? |
|
You can always squash when you approve (Select "Squash + Merge" when merging), but happy to todo it, too. |
…building on MacOs As this seems to be a temporary workaround, just let document it. Otherwise it would have made sense to adapt the Makefile to set it automatically. Fixes apache#297.
rhuss
force-pushed
the
pr/update-contribute-doc
branch
from
750f924
to
ec054fb
Compare
|
Yes but I prefer it to be the developer responsibility, as general rule I would like top keep only relevant commits so it is easier to eventually revert things |
|
ok, I understand. So do you prefer to squash after every commit update (e.g. because of a review comment) or only when it's about to get merged ? |
|
When a PR is about to be merged |
|
thx @rhuss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this seems to be a temporary workaround, just let document it.
Otherwise it would have made sense to adapt the Makefile to set it
automatically.
Fixes #297.