Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Replace existing kamelets #3496

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

bouskaJ
Copy link
Contributor

@bouskaJ bouskaJ commented Jul 28, 2022

Release Note

NONE

@tadayosi
Copy link
Member

@bouskaJ Is it only applicable to 1.8.x and does it not make sense to (back)port to main and 1.9.x?

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Jul 29, 2022

@bouskaJ Is it only applicable to 1.8.x and does it not make sense to (back)port to main and 1.9.x?

yes, I will port it to the other branches but it seems that this fix actually does not work because the custom Kamelet is overridden by the CK operator. It seems that I will need to change the test-kamelet name to avoid collisions.

@christophd
Copy link
Contributor

I think the test should delete and recreate instead of updating the Kamelet. When updating Kubernetes merges the old and new versions patching the changes to the resource. This is why we end up having both flow and template fields in the updated resource which is causing errors.

@bouskaJ bouskaJ force-pushed the create_replace_timer_kamelet branch from c1edf92 to 93fb9b1 Compare July 29, 2022 07:42
@bouskaJ
Copy link
Contributor Author

bouskaJ commented Jul 29, 2022

I noticed that other tests do not install the timer kamelet at all (before using it).

@oscerd oscerd merged commit 6b5e07c into apache:release-1.8.x Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants