fix openapi handling when used in conjunction with deployment.container-image=true #350
Conversation
| if gBuilder != nil { | ||
| return gBuilder, nil | ||
| } | ||
|
|
||
| gBuilder = builder.New(ctx, c, namespace) | ||
| gBuilder = builder.New(context.TODO(), c, namespace) |
There was a problem hiding this comment.
Why creating a temp one and not propagating the existing one? You can pass a context.TODO if a context is not available at caller site.
There was a problem hiding this comment.
The problem is that the builder is created once per platform so if we use the context of the caller, it will be the one of the first caller and it can be closed which causes the builder to stop.
I need to think about a better solution but in a separate pr
lburgazzoli
force-pushed
the
container-image
branch
from
f087dcc
to
fe46dc6
Compare
|
I've polished a little bit action handlers, some new context.TODO() are needed as looking at the code, a context is bound to a single reconcile loop so for things that may happen asynchronously we need a dedicated context. I need to check how this can be improved but will take a little time |
lburgazzoli
force-pushed
the
container-image
branch
from
fe46dc6
to
f89d0ac
Compare
No description provided.