Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build handlers: split buld step in two phases: submit and run #351

Merged
merged 1 commit into from Jan 23, 2019
Merged

build handlers: split buld step in two phases: submit and run #351

merged 1 commit into from Jan 23, 2019

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Jan 21, 2019 •
edited

  • split build phase in submit and run to have a better understanding of what happen
  • add support to cancel an in progress build
  • add consistence check when the build process ends and a resource is about to be updated

@lburgazzoli lburgazzoli added the status/wip Work in progress label Jan 21, 2019
@lburgazzoli lburgazzoli removed the status/wip Work in progress label Jan 22, 2019
@lburgazzoli lburgazzoli force-pushed the split-build-handlers branch 2 times, most recently from 7b832db to 8a77c63 Compare January 23, 2019 05:45
@lburgazzoli
Copy link
Contributor Author

@nicolaferraro ready for review

@lburgazzoli
Copy link
Contributor Author

split

nicolaferraro
nicolaferraro approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

pkg/controller/integration/build_image.go Outdated Show resolved Hide resolved
@nicolaferraro nicolaferraro merged commit 73c23dc into apache:master Jan 23, 2019
@lburgazzoli lburgazzoli deleted the split-build-handlers branch January 23, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lburgazzoli @nicolaferraro