Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable status subresource for integration #352

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Enable status subresource for integration #352

merged 1 commit into from
Jan 22, 2019

Conversation

astefanutti
Copy link
Member

No description provided.

Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great!
I've made sure that the operator code doesn't touch the spec field, but only the status, but it may be subject to error if we don't enforce this rule.

Don't you need additional roles for changing the status?
E.g. look at here: https://github.com/knative/eventing-sources/blob/518626c9b16f6ad45aef00577fbcf3e249e1a584/config/rbac/rbac_role.yaml#L122

My expectation was that roles were not inherited by subresource.

@astefanutti
Copy link
Member Author

That's great!
I've made sure that the operator code doesn't touch the spec field, but only the status, but it may be subject to error if we don't enforce this rule.

I've spent an hour reviewing the entire code to make sure the spec field wasn't updated to realize you had done an amazing job ;)!

Don't you need additional roles for changing the status?
E.g. look at here: https://github.com/knative/eventing-sources/blob/518626c9b16f6ad45aef00577fbcf3e249e1a584/config/rbac/rbac_role.yaml#L122

My expectation was that roles were not inherited by subresource.

Ah very good point. Let me add these additional roles...

@astefanutti
Copy link
Member Author

After a second look at it, the current role definition is enough, as it uses wildcard for all camel.apache.org resources.

@nicolaferraro
Copy link
Member

Right, that's why it's not needed here..

@nicolaferraro nicolaferraro merged commit f7714fe into apache:master Jan 22, 2019
@astefanutti astefanutti deleted the it-status branch January 22, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants