Improvements to OLM bundle building of test index #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadayosi
requested changes
Aug 19, 2022
phantomjinx
force-pushed
the
bundle-gen
branch
from
39a469d
to
394faf0
Compare
* Checks for yq prior to executing bundle index building * ShellChecks fixes: * Handle backslashes when using read * Fixes trap to not expand before executed
phantomjinx
force-pushed
the
bundle-gen
branch
from
394faf0
to
eb19caf
Compare
phantomjinx
changed the title
|
Much of this PR seems to have been superceded and already added so changes here are fixes in response to review comments. Update |
* Functions removed in alternative src file so no longer available. Reverts to original syntax.
tadayosi
approved these changes
Oct 13, 2022
|
The test is failing: |
OK, it's not the PR's fault. Let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note