Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Force arguments for the rebuild command #3556

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

essobedo
Copy link
Contributor

@essobedo essobedo commented Aug 19, 2022

fixes #3445

Motivation

Allowing to accept no arguments to rebuild all the integrations is a bit risky so a new flag for this purpose must be explicitly provided by the end user.

Modifications:

  • Add the flag --all to the rebuild command to rebuild all integrations
  • Sanitize the name of the integration to align the code with the delete command

Release Note

The rebuild command no more supports empty arguments, either the flag `--all` must be set to rebuild all integrations, 
or the list of integration names to rebuild needs to be provided

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few minor change requests.

pkg/cmd/rebuild.go Outdated Show resolved Hide resolved
pkg/cmd/rebuild.go Outdated Show resolved Hide resolved
@tadayosi tadayosi added the kind/feature New feature or request label Aug 22, 2022
@tadayosi tadayosi added this to the 1.10.0 milestone Aug 22, 2022
pkg/cmd/rebuild.go Outdated Show resolved Hide resolved
@essobedo
Copy link
Contributor Author

@tadayosi @squakez Thx for your feedback, actually the remarks that you both raised are about the code that I reused from the delete command for the sake of uniformity since the need is about the same. It is up to you but if I change this, maybe I should also align the code of the delete command, don't you agree?

@squakez
Copy link
Contributor

squakez commented Aug 22, 2022

We can take the opportunity and do the necessary cleaning on the other commands as well.

@essobedo
Copy link
Contributor Author

Ok, No problem, I will do that next week then thx

@tadayosi tadayosi modified the milestones: 1.10.0, 1.11.0 Aug 25, 2022
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@tadayosi tadayosi merged commit eff8256 into main Aug 30, 2022
@tadayosi tadayosi modified the milestones: 1.11.0, 1.10.0 Aug 30, 2022
@essobedo essobedo deleted the 3445/rebuild-filtering branch August 30, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kamel rebuild default should not rebuild all Integrations
4 participants